Messages in this thread Patch in this message | | | From | Ozan Çağlayan <> | Subject | [PATCH] kbuild: Remove useless warning while appending KCFLAGS | Date | Tue, 14 Aug 2012 19:00:54 +0300 |
| |
This is a respin of an older patch sent by Sam Ravnborg: http://www.gossamer-threads.com/lists/linux/kernel/1530602
This patch removes the annoying warning:
Makefile:708: "WARNING: Appending $KCFLAGS (-Wno-sign-compare) from command line to kernel $CFLAGS"
which is printed every time I use KCFLAFS. The commit which introduced the warning:
69ee0b3 kbuild: do not pick up CFLAGS from the environment
tells about the problems when people have CFLAGS in their environment, then switches to KCFLAFS which should be enough to solve the issue, but it anyway introduces a warning. Drop this warning.
Signed-off-by: Ozan Çağlayan <ozancag@gmail.com> --- Makefile | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/Makefile b/Makefile index 0d718ed..34751eb 100644 --- a/Makefile +++ b/Makefile @@ -648,22 +648,9 @@ ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y) endif # Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments -# But warn user when we do so -warn-assign = \ -$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)") - -ifneq ($(KCPPFLAGS),) - $(call warn-assign,CPPFLAGS) - KBUILD_CPPFLAGS += $(KCPPFLAGS) -endif -ifneq ($(KAFLAGS),) - $(call warn-assign,AFLAGS) - KBUILD_AFLAGS += $(KAFLAGS) -endif -ifneq ($(KCFLAGS),) - $(call warn-assign,CFLAGS) - KBUILD_CFLAGS += $(KCFLAGS) -endif +KBUILD_CPPFLAGS += $(KCPPFLAGS) +KBUILD_AFLAGS += $(KAFLAGS) +KBUILD_CFLAGS += $(KCFLAGS) # Use --build-id when available. LDFLAGS_BUILD_ID = $(patsubst -Wl$(comma)%,%,\ -- 1.7.11.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |