Messages in this thread | | | Date | Tue, 14 Aug 2012 11:26:53 -0300 | From | Herton Ronaldo Krzesinski <> | Subject | Re: [PATCH v3 3/6] floppy: avoid leaking extra reference to queue on do_floppy_init error handling |
| |
On Tue, Aug 14, 2012 at 11:03:30AM +0200, Stanislaw Gruszka wrote: > On Tue, Aug 14, 2012 at 04:20:39AM +0100, Ben Hutchings wrote: > > It's totally ridiculous that a driver should have to do this. Any > > registered disk should have the GENHD_FL_UP flag set... so why can't > > genhd check it? It doesn't look like floppy is the only driver affected > > by this problem, either. So I suggest the following general fix > > (untested): > > > > --- > > Subject: genhd: Make put_disk() safe for disks that have not been registered > > > > Since commit 9f53d2f ('block: fix __blkdev_get and add_disk race > > condition'), add_disk() adds a reference to disk->queue, > > I do not see this? Commit 9f53d2fe insert disk_alloc_events() to add_disk(), > but disk_alloc_events() function does not get any reference to disk->queue, > I missed something?
I think he meant commit 523e1d3 ("block: make gendisk hold a reference to its queue") instead.
> > Stanislaw >
-- []'s Herton
| |