Messages in this thread | | | Date | Tue, 14 Aug 2012 09:25:52 +0800 | From | Feng Tang <> | Subject | Re: [PATCH RFT 1/2] gpio: gpio-ml-ioh: Use spinlock for register access protection |
| |
On Mon, 13 Aug 2012 14:01:31 +0200 Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Jul 29, 2012 at 4:54 AM, Axel Lin <axel.lin@gmail.com> wrote: > > > gpio_chip.can_sleep is 0, but current code uses mutex in ioh_gpio_set, > > ioh_gpio_get and ioh_gpio_direction_input functions. > > Thus those functions are not callable from interrupt context. > > This patch converts mutex into spinlock. > > > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > > So IOH guys what are you saying about this?
I'm not the IOH guy, but just happened to work on it for some time :) Anyway, the 2 patches both look good to me.
Thanks, Feng
| |