Messages in this thread | | | Date | Mon, 13 Aug 2012 18:01:09 +0100 | From | Al Viro <> | Subject | Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic |
| |
On Mon, Aug 13, 2012 at 09:58:12AM -0700, John Fastabend wrote: > [...] > > >HOWEVER, it still doesn't address more fundamental problem - somebody > >creating a socket and passing it to you in SCM_RIGHTS datagram will > >leave you with a socket you can do IO on, still tagged according to who > >had created it. > > > >AFAICS, the whole point of that exercise was to allow third-party changing > >the priorities of traffic on sockets already created by a process we now > >move to a different cgroup. Consider e.g. this: > > Correct that is the point of the exercise. > > To fix this specific case we could add a call to sock_update_netprioidx > in scm_recv to set the sk_cgrp_prioidx value.
On every received descriptor, that is? Eeek...
| |