Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH] TTY: mxser, fix invalid module_parm permissions | Date | Mon, 13 Aug 2012 10:16:17 +0200 |
| |
444 means 0674 and we do not definitely want that. Use S_IRUGO which is much more safer.
Signed-off-by: Jiri Slaby <jslaby@suse.cz> Reported-by: Rusty Russell <rusty@ozlabs.org> --- drivers/tty/mxser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index 8bc2651..bb2da4c 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -2338,7 +2338,7 @@ static struct tty_port_operations mxser_port_ops = { */ static bool allow_overlapping_vector; -module_param(allow_overlapping_vector, bool, 444); +module_param(allow_overlapping_vector, bool, S_IRUGO); MODULE_PARM_DESC(allow_overlapping_vector, "whether we allow ISA cards to be configured such that vector overlabs IO ports (default=no)"); static bool mxser_overlapping_vector(struct mxser_board *brd) -- 1.7.10.4
| |