lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 79/82] e1000e: NIC goes up and immediately goes down
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Tushar Dave <tushar.n.dave@intel.com>

    commit b7ec70be01a87f2c85df3ae11046e74f9b67e323 upstream.

    Found that commit d478eb44 was a bad commit.
    If the link partner is transmitting codeword (even if NULL codeword),
    then the RXCW.C bit will be set so check for RXCW.CW is unnecessary.
    Ref: RH BZ 840642

    Reported-by: Fabio Futigami <ffutigam@redhat.com>
    Signed-off-by: Tushar Dave <tushar.n.dave@intel.com>
    CC: Marcelo Ricardo Leitner <mleitner@redhat.com>
    Tested-by: Aaron Brown <aaron.f.brown@intel.com>
    Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/ethernet/intel/e1000e/82571.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/net/ethernet/intel/e1000e/82571.c
    +++ b/drivers/net/ethernet/intel/e1000e/82571.c
    @@ -1601,10 +1601,8 @@ static s32 e1000_check_for_serdes_link_8
    * auto-negotiation in the TXCW register and disable
    * forced link in the Device Control register in an
    * attempt to auto-negotiate with our link partner.
    - * If the partner code word is null, stop forcing
    - * and restart auto negotiation.
    */
    - if ((rxcw & E1000_RXCW_C) || !(rxcw & E1000_RXCW_CW)) {
    + if (rxcw & E1000_RXCW_C) {
    /* Enable autoneg, and unforce link up */
    ew32(TXCW, mac->txcw);
    ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));



    \
     
     \ /
      Last update: 2012-08-14 00:02    [W:3.181 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site