Messages in this thread | | | Date | Mon, 13 Aug 2012 13:22:46 -0300 | From | Herton Ronaldo Krzesinski <> | Subject | Re: [PATCH 5/6] floppy: remove check for allocated queue on do_floppy_init error handling |
| |
On Fri, Aug 10, 2012 at 01:36:53PM -0400, Vivek Goyal wrote: > On Thu, Aug 09, 2012 at 04:59:50PM -0300, Herton Ronaldo Krzesinski wrote: > > The check "if (disks[dr]->queue)" check is bogus, if we reach there > > for each dr should exist an queue allocated (note that we decrement dr > > first on entering the loop). > > > > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com> > > As mentioned in second patch, I like going trhough full array of drives > and do cleanup as needed instead of relying on "dr" variable. > > But if you don't like that, then I am not as such against this approach. > Was just trying to keep all put_disk() at one place.
Ok, I'll drop this, and do a full cleanup. I just ended up doing the minimal work, but I'm not against cleaning this. I still want to keep the second patch, as being a simple/appropriate bug fix for stable. I'll submit a new series soon. Thanks for looking at this series.
> > Thanks > Vivek >
-- []'s Herton
| |