lkml.org 
[lkml]   [2012]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] efikamx: reintroduce Genesi Efika MX Smarttop via device tree
    On Thu, Aug 9, 2012 at 5:19 AM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    > On Tue, Aug 07, 2012 at 04:46:18PM -0500, Matt Sealey wrote:
    >
    > Yay for indentation! It'd be good to rewrite your DT so you could cut
    > down on that, at the minute it's not good for legibility.
    >
    >> + sw1_reg: sw1 {
    >> + regulator-min-microvolt = <600000>;
    >> + regulator-max-microvolt = <1375000>;
    >> + regulator-boot-on;
    >> + regulator-always-on;
    >> + };
    >
    > This and many of your other regulators have voltage ranges specified but
    > no consumers which doesn't make sense. It looks awfully like you've
    > just typed in the maximum range supported by the regulator which is most
    > likely broken.

    Okay I have a question about this; some of the regulators (SW1
    especially) are obviously consumed by the CPU core complex so that
    when DVFS gives us a hint we can clock down and reduce voltage. How on
    earth do we implement that?

    We can drop the maximum range to be better for the CPU (1.3V is too
    high, I think this is legacy from when we may have had a sorted 1GHz
    MX51 coming out) but I can't find any source for where this is hooked
    in.

    --
    Matt Sealey <matt@genesi-usa.com>
    Product Development Analyst, Genesi USA, Inc.


    \
     
     \ /
      Last update: 2012-08-13 18:23    [W:3.218 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site