Messages in this thread | | | Date | Mon, 13 Aug 2012 15:24:38 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] perf: Let O= makes handle relative paths |
| |
On Mon, Aug 13, 2012 at 09:20:55AM -0400, Steven Rostedt wrote: > When I did a compile of perf using a relative path for the output > directory, the build failed when it tried to compile libtraceevent. This > is because it continues to use the same relative path when the new > working directory is in a different path. > > SUBDIR ../lib/traceevent/ > /bin/sh: line 0: cd: ../../../nobackup/perf/: No such file or directory > Makefile:74: *** output directory "../../../nobackup/perf/" does not exist. Stop. > make: *** [../../../nobackup/perf///libtraceevent.a] Error 2 > > > Make the path used an absolute path when building perf with O=. > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > > diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include > index bde8521..9e3e31e 100644 > --- a/tools/scripts/Makefile.include > +++ b/tools/scripts/Makefile.include > @@ -1,6 +1,7 @@ > ifeq ("$(origin O)", "command line") > - OUTPUT := $(O)/ > - COMMAND_O := O=$(O) > + RAW_O := $(shell cd $(O) ; pwd) > + OUTPUT := $(RAW_O)/ > + COMMAND_O := O=$(RAW_O)
So wouldn't it make sense to call this ABSOLUTE_O or so then?
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |