Messages in this thread | | | Date | Mon, 13 Aug 2012 18:51:08 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 3/7] uprobes: change uprobe_mmap() to ignore the errors but check fatal_signal_pending() |
| |
* Oleg Nesterov <oleg@redhat.com> [2012-08-08 19:37:42]:
> Once install_breakpoint() fails uprobe_mmap() "ignores" all other > uprobes and returns the error. > > It was never really needed to to stop after the first error, and > in fact it was always wrong at least in -ENOTSUPP case. > > Change uprobe_mmap() to ignore the errors and always return 0. > This is not what we want in the long term, but until we teach > the callers to handle the failure it would be better to remove > the pointless complications. And this doesn't look too bad, the > only "reasonable" error is ENOMEM but in this case the caller > should be oom-killed in the likely case or the system has more > serious problems. > > However it makes sense to stop if fatal_signal_pending() == T. > In particular this helps if the task was oom-killed. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
| |