Messages in this thread Patch in this message | | | Date | Mon, 13 Aug 2012 19:13:43 +0800 | From | Xiao Guangrong <> | Subject | [PATCH 02/12] thp: remove unnecessary check in start_khugepaged |
| |
The check is unnecessary since if mm_slot_cache or mm_slots_hash initialize failed, no sysfs interface will be created
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> --- mm/huge_memory.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 80bcd42..399e8c9 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -140,10 +140,7 @@ static int start_khugepaged(void) int err = 0; if (khugepaged_enabled()) { int wakeup; - if (unlikely(!mm_slot_cache || !mm_slots_hash)) { - err = -ENOMEM; - goto out; - } + mutex_lock(&khugepaged_mutex); if (!khugepaged_thread) khugepaged_thread = kthread_run(khugepaged, NULL, @@ -163,7 +160,7 @@ static int start_khugepaged(void) } else /* wakeup to exit */ wake_up_interruptible(&khugepaged_wait); -out: + return err; }
-- 1.7.7.6
| |