Messages in this thread Patch in this message | | | From | John David Anglin <> | Subject | Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant | Date | Sun, 12 Aug 2012 09:00:39 -0400 |
| |
On 11-Aug-12, at 10:42 PM, Michael Cree wrote:
> On 12/08/12 14:10, Fengguang Wu wrote: >> On Sun, Aug 12, 2012 at 01:33:09PM +1200, Michael Cree wrote: >>> On 03/08/12 03:02, Fengguang Wu wrote: >>>> On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote: >>>>> On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley >>>>> <James.Bottomley@hansenpartnership.com> wrote: >>>>>>> Here is the line in sock.i: >>>>>>> >>>>>>> struct static_key memalloc_socks = ((struct static_key) >>>>>>> { .enabled = >>>>>>> ((atomic_t) { (0) }) }); >>>>>> >>>>>> The above line contains two compound literals. It also uses a >>>>>> designated >>>>>> initializer to initialize the field enabled. A compound >>>>>> literal is not a >>>>>> constant expression. >>>>> >>>>> Seeing the same thing on ia64 building next-20120726. Same fix >>>>> works >>>>> for me ... so I'll steal this whole changelog and attributes. >>>> >>>> I got the same error for alpha, the same fix applies. >>> >>> Just trying this patch on Alpha against v3.6-rc1 and it leads to new >>> compilation errors, namely: >>> >>> init/init_task.c:12: error: braced-group within expression allowed >>> only >>> inside a function >>> init/init_task.c:13: error: braced-group within expression allowed >>> only >>> inside a function >>> init/init_task.c:16: error: braced-group within expression allowed >>> only >>> inside a function >>> init/init_task.c:16: error: braced-group within expression allowed >>> only >>> inside a function >>> make[1]: *** [init/init_task.o] Error 1 >> >> Sorry! This will actually compile: >> >> -#define ATOMIC_INIT(i) ( { (i) } ) >> +#define ATOMIC_INIT(i) { (i) } > > Thanks, it now compiles correctly. I'm currently collecting Alpha > patches to send on to Linus so will include this one.
A similar change applied to 3.5.1 stable compiles successfully on parisc.
Regards, Dave -- John David Anglin dave.anglin@bell.net
diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h index 6c6defc..af9cf30 100644 --- a/arch/parisc/include/asm/atomic.h +++ b/arch/parisc/include/asm/atomic.h @@ -141,7 +141,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) #define atomic_sub_and_test(i,v) (atomic_sub_return((i),(v)) == 0) -#define ATOMIC_INIT(i) ((atomic_t) { (i) }) +#define ATOMIC_INIT(i) { (i) } #define smp_mb__before_atomic_dec() smp_mb() #define smp_mb__after_atomic_dec() smp_mb() @@ -150,7 +150,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) #ifdef CONFIG_64BIT -#define ATOMIC64_INIT(i) ((atomic64_t) { (i) }) +#define ATOMIC64_INIT(i) { (i) } static __inline__ s64 __atomic64_add_return(s64 i, atomic64_t *v) | |