Messages in this thread | | | Date | Mon, 13 Aug 2012 08:38:28 +0800 | From | "Jianpeng Ma" <> | Subject | Re: Re: [PATCH] block: Don't use static to define "void *p" in show_partition_start(). |
| |
On 2012-08-12 23:45 Michael Tokarev <mjt@tls.msk.ru> Wrote: >On 03.08.2012 12:41, Jens Axboe wrote: >> On 08/03/2012 07:07 AM, majianpeng wrote: >[] >>> diff --git a/block/genhd.c b/block/genhd.c >>> index cac7366..d839723 100644 >>> --- a/block/genhd.c >>> +++ b/block/genhd.c >>> @@ -835,7 +835,7 @@ static void disk_seqf_stop(struct seq_file *seqf, void *v) >>> >>> static void *show_partition_start(struct seq_file *seqf, loff_t *pos) >>> { >>> - static void *p; >>> + void *p; >>> >>> p = disk_seqf_start(seqf, pos); >>> if (!IS_ERR_OR_NULL(p) && !*pos) >> >> Huh, that looks like a clear bug. I've applied it, thanks. > >It also looks like a -stable material, don't you think? > >Thanks, > >/mjt > Yes, all kernel before this patach had this problem and should apply this patch. | |