lkml.org 
[lkml]   [2012]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 14/15] sh: MTU2: Basic runtime PM support
Date
On Saturday, August 11, 2012, Geert Uytterhoeven wrote:
> On Mon, Aug 6, 2012 at 1:49 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > @@ -341,8 +346,19 @@ static int __devinit sh_mtu2_probe(struc
> > if (ret) {
> > kfree(p);
> > platform_set_drvdata(pdev, NULL);
> > + pm_runtime_idle(&pdev->dev);
> > + return ret;
> > }
> > - return ret;
> > + if (is_early_platform_device(pdev))
> > + return 0;
> > +
> > + out:
> > + if (cfg->clockevent_rating)
>
> drivers/clocksource/sh_mtu2.c:356:6: error: 'cfg' undeclared (first
> use in this function)
> http://kisskb.ellerman.id.au/kisskb/buildresult/6883515/
>
> Presumably there's a
>
> struct sh_timer_config *cfg = p->pdev->dev.platform_data;
>
> missing at the top of sh_mtu2_probe()

Precisely.

It should be fixed now, thanks for the report!

Rafael


\
 
 \ /
  Last update: 2012-08-12 01:01    [W:0.895 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site