lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] pwm: core: Fix coding style issues
From
On 10 August 2012 15:32, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> On Fri, Aug 10, 2012 at 03:29:08PM +0530, Sachin Kamat wrote:
>> On 10 August 2012 15:25, Thierry Reding
>> <thierry.reding@avionic-design.de> wrote:
>> > On Fri, Aug 10, 2012 at 10:12:10AM +0530, Sachin Kamat wrote:
>> >> Fixes the following:
>> >> WARNING: line over 80 characters
>> >> ERROR: spaces required around that ':' (ctx:VxW)
>> >> WARNING: Prefer pr_warn(... to pr_warning(...
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> >> ---
>> >> drivers/pwm/core.c | 6 +++---
>> >> 1 files changed, 3 insertions(+), 3 deletions(-)
>> >>
>> >> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
>> >> index efc20f8..929be13 100644
>> >> --- a/drivers/pwm/core.c
>> >> +++ b/drivers/pwm/core.c
>> >> @@ -130,7 +130,7 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label)
>> >> }
>> >>
>> >> static struct pwm_device *of_pwm_simple_xlate(struct pwm_chip *pc,
>> >> - const struct of_phandle_args *args)
>> >> + const struct of_phandle_args *args)
>> >> {
>> >> struct pwm_device *pwm;
>> >>
>> >
>> > Can this hunk be removed, please? I think aligning the arguments is more
>> > useful than respecting the 80-columns limit.
>>
>> Sure, if you think so. Anyway it was just one space deleted. Do you
>> want me to re-send the patch?
>
> No, with your permission, I'll just leave that hunk out and remove the
> "WARNING: line over 80 characters" line from the commit message.

OK. That is fine with me.
Thanks.

>
> Thierry



--
With warm regards,
Sachin


\
 
 \ /
  Last update: 2012-08-10 12:43    [W:0.113 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site