Messages in this thread | | | From | Axel Lin <> | Date | Sat, 11 Aug 2012 10:22:54 +0800 | Subject | Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators |
| |
2012/8/10 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: >> 2012/8/10 Mark Brown <broonie@opensource.wolfsonmicro.com>: > >> > We should be failing to register these regulators in the first place, or >> > at least complaining extremely loudly about them. > >> Oh. My original intention is to prevent using list_voltage() to read >> voltage regulators for the case "n_voltages > 1" in case of both get_voltage >> and get_voltage_sel are not implemented. > > Yes, I see the intention - what I'm saying is that a regulator like that > makes no sense in the first place.
We do have such case in drivers/regulator/max1586.c
/* * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back * the set up value. */ static struct regulator_ops max1586_v3_ops = { .set_voltage_sel = max1586_v3_set_voltage_sel, .list_voltage = regulator_list_voltage_linear, .map_voltage = regulator_map_voltage_linear, };
static struct regulator_ops max1586_v6_ops = { .set_voltage_sel = max1586_v6_set_voltage_sel, .list_voltage = regulator_list_voltage_table, };
| |