lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/16] perf symbol: simplify out_fixup in kernel syms loading
    Date
    The only site that jumps to out_fixup has (kallsyms_filename == NULL).
    And all paths that reach 'if (err > 0)' without 'goto out_fixup' have
    kallsyms_filename != NULL.

    So skip over both the check & dso__set_long_name(), and remove the
    check.

    Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
    ---
    tools/perf/util/symbol.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
    index 2127002..e5c3817 100644
    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -1503,9 +1503,8 @@ do_kallsyms:
    free(kallsyms_allocated_filename);

    if (err > 0) {
    + dso__set_long_name(dso, strdup("[kernel.kallsyms]"));
    out_fixup:
    - if (kallsyms_filename != NULL)
    - dso__set_long_name(dso, strdup("[kernel.kallsyms]"));
    map__fixup_start(map);
    map__fixup_end(map);
    }
    --
    1.7.11.3


    \
     
     \ /
      Last update: 2012-08-11 01:42    [W:3.600 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site