lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/16] perf symbol: only set vmlinux longname & mark loaded if really loaded
    Date
    dso__load_vmlinux() uses the filename passed to it to directly set the
    dso long_name, which resulted in a use after free due to
    dso__load_vmlinux_path() treating 0 symbols as a load failure and
    subsequently freeing the contents of dso->long_name.

    Change dso__load_vmlinux() so that finding 0 symbols does not cause it
    to consider itself loaded, and do not set long_name in such a case.

    Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
    ---
    tools/perf/util/symbol.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
    index e5c3817..96dbf28 100644
    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -1364,13 +1364,14 @@ int dso__load_vmlinux(struct dso *dso, struct map *map,
    if (fd < 0)
    return -1;

    - dso__set_long_name(dso, (char *)vmlinux);
    - dso__set_loaded(dso, map->type);
    err = dso__load_sym(dso, map, symfs_vmlinux, fd, filter, 0, 0);
    close(fd);

    - if (err > 0)
    + if (err > 0) {
    + dso__set_long_name(dso, (char *)vmlinux);
    + dso__set_loaded(dso, map->type);
    pr_debug("Using %s for symbols\n", symfs_vmlinux);
    + }

    return err;
    }
    --
    1.7.11.3


    \
     
     \ /
      Last update: 2012-08-11 01:42    [W:4.293 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site