Messages in this thread | | | Date | Fri, 10 Aug 2012 10:11:45 -0700 | From | Cody P Schafer <> | Subject | Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb |
| |
> I guess that length of 1 effectively same as zero length in this case > since we end up calling symbols__fixup_end. The 'end - start + 1' part > looks like a leftover from previous change and not needed anymore - > KSYM_NAME_LEN check too, IMHO - so I suggest using 0 length to make it > clear.
Got it.
> And it seems you need to rebase the series onto Arnaldo's current > perf/core branch which separates out ELF bits to symbol-elf.c.
Will do. It apparently wasn't pushed out when I sent these patches, look for v2 shortly.
| |