lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 08/10] ARM: s3c24xx: enable CONFIG_BUG for tct_hammer
    Date
    Arnd Bergmann wrote:
    >
    > Disabling CONFIG_BUG creates an insane amount of build warnings, which
    > makes it useless to check for building defconfigs to see if new
    > warnings show up.
    >
    > Without this patch, building tct_hammer_defconfig results in:
    >
    > net/packet/af_packet.c: In function 'tpacket_rcv':
    > net/packet/af_packet.c:1889:30: warning: 'hdrlen' may be used
    > uninitialized in this function [-Wuninitialized]
    > net/core/ethtool.c: In function 'ethtool_get_feature_mask':
    > net/core/ethtool.c:213:1: warning: control reaches end of non-void
    > function [-Wreturn-type]
    > block/cfq-iosched.c: In function 'cfq_async_queue_prio':
    > block/cfq-iosched.c:2914:1: warning: control reaches end of non-void
    > function [-Wreturn-type]
    > mm/bootmem.c: In function 'mark_bootmem':
    > mm/bootmem.c:352:1: warning: control reaches end of non-void function [-
    > Wreturn-type]
    > net/core/dev.c: In function 'skb_warn_bad_offload':
    > net/core/dev.c:1904:33: warning: unused variable 'null_features' [-
    > Wunused-variable]
    > drivers/mtd/chips/cfi_probe.c: In function 'cfi_chip_setup':
    > include/linux/mtd/cfi.h:489:3: warning: 'r.x[0]' may be used uninitialized
    > in this function [-Wuninitialized]
    > include/linux/mtd/map.h:394:11: note: 'r.x[0]' was declared here
    > include/linux/mtd/cfi.h:489:3: warning: 'r.x[0]' may be used uninitialized
    > in this function [-Wuninitialized]
    > (and many more)
    >
    > The size of vmlinux increases by 1.78% because of this:
    >
    > size obj-arm/vmlinux.nobug
    > text data bss dec hex filename
    > 2108474 116916 55352 2280742 22cd26 obj-arm/vmlinux
    > size obj-arm/vmlinux.bug
    > text data bss dec hex filename
    > 2150804 116916 53696 2321416 236c08 obj-arm/vmlinux
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Cc: Kukjin Kim <kgene.kim@samsung.com>

    Acked-by: Kukjin Kim <kgene.kim@samsung.com>

    BTW, I'm not sure we should still keep the tct_hammer_defconfig because
    s3c2410_defconfig is including MACH_TCT_HAMMER, its selection are different
    though.

    Thanks.

    Best regards,
    Kgene.
    --
    Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
    SW Solution Development Team, Samsung Electronics Co., Ltd.


    > Cc: Ben Dooks <ben-linux@fluff.org>
    > ---
    > arch/arm/configs/tct_hammer_defconfig | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/arm/configs/tct_hammer_defconfig
    > b/arch/arm/configs/tct_hammer_defconfig
    > index 1d24f84..71277a1 100644
    > --- a/arch/arm/configs/tct_hammer_defconfig
    > +++ b/arch/arm/configs/tct_hammer_defconfig
    > @@ -7,7 +7,7 @@ CONFIG_SYSFS_DEPRECATED_V2=y
    > CONFIG_BLK_DEV_INITRD=y
    > CONFIG_EXPERT=y
    > # CONFIG_KALLSYMS is not set
    > -# CONFIG_BUG is not set
    > +# CONFIG_BUGVERBOSE is not set
    > # CONFIG_ELF_CORE is not set
    > # CONFIG_SHMEM is not set
    > CONFIG_SLOB=y
    > --
    > 1.7.10



    \
     
     \ /
      Last update: 2012-08-10 08:42    [W:2.694 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site