Messages in this thread | | | Date | Fri, 10 Aug 2012 15:51:27 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 01/15] Proc entry showing inodes on sockfs and types |
| |
> +#ifdef CONFIG_PROC_FS > + /* Set non-zero value if this protocol manages its > + own /proc/net/PROTOCOL entry and the entry has inode column. */ > + int has_own_proc_entry; > +#endif
Is it really worth ifdefs in every file for what is (or should be) a bool value in the protocol structs of which there are not many
> }; > > /* > diff --git a/net/socket.c b/net/socket.c > index dfe5b66..4044b58 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -105,6 +105,10 @@ > #include <linux/sockios.h> > #include <linux/atalk.h> > > +#ifdef CONFIG_PROC_FS > +#include <linux/rwlock_types.h> > +#endif
You can include it anyway and that makes it easier to avoid bugs
| |