Messages in this thread | | | Date | Fri, 10 Aug 2012 21:39:21 +0800 | Subject | Re: [patch] hugetlb: correct page offset index for sharing pmd | From | Hillf Danton <> |
| |
On Fri, Aug 10, 2012 at 9:21 PM, Hillf Danton <dhillf@gmail.com> wrote: > On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko <mhocko@suse.cz> wrote: >> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for >> vma_prio_tree_foreach >> >> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page >> from vma) fixed pgoff calculation but it has replaced it by >> vma_hugecache_offset which is not approapriate for offsets used for >> vma_prio_tree_foreach because that one expects index in page units >> rather than in huge_page_shift. >> Using vma_hugecache_offset is not incorrect because the pgoff will fit >> into the same vmas but it is confusing. >> > > Well, how is the patch tested?
You see, Michal, it is weekend and I have to be offline now.
See you next week ;)
Hillf
| |