lkml.org 
[lkml]   [2012]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch] mmap: feed back correct prev vma when finding vma
From
On Fri, Aug 10, 2012 at 9:26 AM, Hugh Dickins <hughd@google.com> wrote:
> On Thu, 9 Aug 2012, Hillf Danton wrote:
>> After walking rb tree, if vma is determined, prev vma has to be determined
>> based on vma; and rb_prev should be considered only if no vma determined.
>
> Why? Because you think more code is better code? I disagree.

s/more/correct/

Because feedback is incorrect if we return vma corresponding to
the root node.

Hillf


\
 
 \ /
  Last update: 2012-08-10 14:42    [W:0.051 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site