Messages in this thread | | | Date | Wed, 01 Aug 2012 11:41:19 +0300 | From | Avi Kivity <> | Subject | Re: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set |
| |
On 08/01/2012 06:19 AM, Marcelo Tosatti wrote: > On Thu, Jul 26, 2012 at 02:22:48PM +0200, Markus Trippelsdorf wrote: >> Every time I start qemu-kvm on my system the following line is added to >> the syslog: >> >> vcpu0 unhandled rdmsr: 0xc0010001 >> >> AFAICS all calls to vcpu_unimpl only contain debugging info with little >> or no value for the end user. >> >> Wouldn't something like the following patch make sense? >> >> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de> > > It could be useful for debugging (but then lots of other things could). > > Anyone has a use for this?
The current scenario is:
<guest breaks> Maintainer asks for dmesg If something shows up, it's something to consider
Following this patch, the scenario will be
<guest breaks> Maintainer: please enable dynamic debug for kvm and reproduce If something shows up, it's something to consider
I guess with dynamic debug it's acceptable, we just need to make sure that it doesn't spew tons of other stuff.
-- error compiling committee.c: too many arguments to function
| |