Messages in this thread | | | Date | Wed, 1 Aug 2012 18:49:11 -0700 | From | Jon Mason <> | Subject | Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support |
| |
On Tue, Jul 31, 2012 at 03:25:55PM -0700, Greg KH wrote: > On Sun, Jul 29, 2012 at 05:26:33PM -0700, Jon Mason wrote: > > +struct ntb_transport_qp; > > + > > +struct ntb_client { > > + char *name; > > + int (*probe) (struct pci_dev *pdev); > > + void (*remove) (struct pci_dev *pdev); > > +}; > > Why isn't this tied into the driver model? That looks like you really > want to use a 'struct device' here, right? > > Then you have drivers that bind to them, and your devices show up in > sysfs, which is probably a requirement you have, right?
I was trying to do something more light-weight than that and avoid the complexity, but this is probably the direction it needs to go.
Thanks, Jon
> > greg k-h
| |