Messages in this thread | | | Date | Wed, 1 Aug 2012 20:03:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: initialize all irqs to wake disabled |
| |
On Wed, Aug 01, 2012 at 11:39:44AM -0600, Stephen Warren wrote:
> and sets bits to disable wake. Hence, we should set all bits in > wake_buf initially, to mirror the expected disabled state.
This fortunately isn't an issue for the only current user as masked is the default in the silicon.
> + ret = regmap_write(map, reg, d->wake_buf[i]); > + if (ret != 0) { > + dev_err(map->dev, "Failed to set masks in 0x%x: %d\n", > + reg, ret);
This should really be update_bits(). Which is a mistake we're making in the current code for the masks and should correct there (I'll send a patch shortly) but we may as well get it right here.
| |