lkml.org 
[lkml]   [2012]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: initialize all irqs to wake disabled
On Wed, Aug 01, 2012 at 11:39:44AM -0600, Stephen Warren wrote:

> and sets bits to disable wake. Hence, we should set all bits in
> wake_buf initially, to mirror the expected disabled state.

This fortunately isn't an issue for the only current user as masked is
the default in the silicon.

> + ret = regmap_write(map, reg, d->wake_buf[i]);
> + if (ret != 0) {
> + dev_err(map->dev, "Failed to set masks in 0x%x: %d\n",
> + reg, ret);

This should really be update_bits(). Which is a mistake we're making
in the current code for the masks and should correct there (I'll send a
patch shortly) but we may as well get it right here.


\
 
 \ /
  Last update: 2012-08-01 21:41    [W:0.038 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site