Messages in this thread | | | Date | Wed, 01 Aug 2012 14:50:32 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too |
| |
On 01/08/12 14:20, Mark Brown wrote: > On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote: >> On 31/07/12 16:18, Mark Brown wrote: > >>> I'm not going to apply this patch. This isn't a vendor BSP, we >>> shouldn't be putting random hacks like this in core code. > >> BSP kernel or otherwise, it still seems wrong to me to fail and >> entire audio driver just because of a broken link. > > No, really. Random disconnections in the DAPM graph are just endless > pain from a support and debug point of view. This isn't something that > randomly breaks on specific hardware where we'd expect random errors at > runtime, it's something that will never have worked - it seems clear > nobody tested the mainline submission.
I am under the impression that it was tested. Perhaps before it was rebased, but tests were completed. Ola was very surprised when I told him there were link failures. The only issue is that I only found out and told him a day before he was due to take his Summer leave.
> It's very disappointing to see such an error exist, and even more > disappointing that there's no interest in fixing the driver.
This is incorrect. I'm sure the driver will be fixed post-haste when Ola returns back from vacation. If I can find some time I might dabble in the mean-time also.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |