Messages in this thread | | | Date | Wed, 1 Aug 2012 14:24:43 +0200 | From | Fabio Baltieri <> | Subject | Re: [PATCH can-next v5 2/2] can: flexcan: add LED trigger support |
| |
On Wed, Aug 01, 2012 at 01:53:22PM +0200, Marc Kleine-Budde wrote: [...] > > @@ -635,6 +638,7 @@ static irqreturn_t flexcan_irq(int irq, void *dev_id) > > if (reg_iflag1 & (1 << FLEXCAN_TX_BUF_ID)) { > > stats->tx_bytes += can_get_echo_skb(dev, 0); > > stats->tx_packets++; > > + can_led_event(dev, CAN_LED_EVENT_TX); > > Should the led blink on TX or TX completion interrupt?
I'd say on complention interrupt, together with can_get_echo_skb().
That was briefly discussed with Oliver in my first patch:
http://article.gmane.org/gmane.linux.can/1007
Fabio
| |