Messages in this thread | | | Subject | Re: [PATCH 4/5] uprobes: kill copy_vma()->uprobe_mmap() | From | Peter Zijlstra <> | Date | Mon, 09 Jul 2012 10:35:57 +0200 |
| |
On Sun, 2012-07-08 at 22:30 +0200, Oleg Nesterov wrote: > And why this uprobe_mmap() was added? I believe the intent was wrong. > Note that the caller is going to do move_page_tables(), all registered > uprobes are already faulted in, we only change the virtual addresses. >
I think it was because of the copy_vma + do_munmap. Since do_munmap() should be doing a put on the uprobe, we need an extra get to balance.
That said, I cannot actually find the uprobe_munmap() from do_munmap(), but that might be due to lack of wakefulness etc..
| |