| Date | Mon, 09 Jul 2012 12:26:46 +0900 | From | Kamezawa Hiroyuki <> | Subject | Re: [patch 10/11] mm: memcg: only check swap cache pages for repeated charging |
| |
(2012/07/05 9:45), Johannes Weiner wrote: > Only anon and shmem pages in the swap cache are attempted to be > charged multiple times, from every swap pte fault or from > shmem_unuse(). No other pages require checking PageCgroupUsed(). > > Charging pages in the swap cache is also serialized by the page lock, > and since both the try_charge and commit_charge are called under the > same page lock section, the PageCgroupUsed() check might as well > happen before the counter charging, let alone reclaim. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
You're right. This is SwapCache handling is done by commit d13d144309d... I should notice this....
Thank you very much !
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
|