lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: vt6656: iwctl: remove a few remaining redundant newlines
On Sun, 8 Jul 2012, Joe Perches wrote:

> On Mon, 2012-07-09 at 00:59 +0200, Jesper Juhl wrote:
> > I missed a few redundant newlines the first time.
> []
> > diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> []
> > @@ -964,7 +964,6 @@ int iwctl_giwrts(struct net_device *dev, struct iw_request_info *info,
> > wrq->value = pDevice->wRTSThreshold;
> > wrq->disabled = (wrq->value >= 2312);
> > wrq->fixed = 1;
> > -
> > return 0;
> > }
>
> I think this is a useful style and these should not be removed.
> It's akin to a blank line after automatic variable declarations.
>
Thank you for your feedback Joe.

I see your point, but personally I'd rather leave it out - especially for
small functions.

I'll leave it up to Greg whether or not to take this one :-)


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2012-07-09 02:01    [W:0.070 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site