lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Fix checkpatch.pl issue.
From
I agree.

On Sun, Jul 8, 2012 at 5:36 PM, Jan Ceuleers <jan.ceuleers@computer.org> wrote:
> On 07/08/2012 10:16 AM, Toshiaki Yamane wrote:
>> -printk(KERN_ERR, to pr_err(...
>>
>> Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
>
> Hi
>
> I submit that your subject line should be more descriptive. Perhaps
> something like the following:
>
> [PATCH] asus_oled: Use pr_err(...) rather than printk(KERN_ERR ...)
>
> The rest of your commit message could then clarify that this change was
> inspired by checkpatch.
>
> HTH, Jan



--

Regards,


.
.
...

Yamane Toshiaki

yamanetoshi@gmail.com


\
 
 \ /
  Last update: 2012-07-08 11:41    [W:0.059 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site