Messages in this thread | | | From | hayeswang <> | Subject | RE: [PATCH v2 net-next 2/2] r8169: support RTL8168G | Date | Fri, 6 Jul 2012 15:57:09 +0800 |
| |
Francois Romieu [romieu@fr.zoreil.com] [...] > > Any objection against merging it with the patch below ? > > - more BUG() avoidance > - save Joe P. some work > - remove useless parenthesis > - fix r8168g_mdio_write (if (reg_addr == 0x1f) { if (reg_addr == 0) snafu) > -> Please check this one.
That is fine.
> - long declarations before short ones > - avoid unbounded loops > - use a descriptive name for the 0xe8de value in rtl_hw_init_8168g. > -> Please suggest something better than "PLOP"
I have no idea about naming 0xe8de. Our hardware engineers don't release any datasheet about it. It seems to be related with oob settings. [unhandled content-type:application/octet-stream] | |