Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [RFC][PATCH 2/2] write callback: Check if existing entry is erasable | Date | Thu, 5 Jul 2012 23:12:42 +0000 |
| |
> Default value of pstore.kmsg_byte is 10KB. > I think efi_pstore can log 60KB(= 10KB X 6)...
10K is almost certainly more than we need for 99.9% of problems ... I set the default there to test out that pstore would correctly break a dump into more than one back-end ERST record (about 7K) and never changed it back. So don't treat 10K with any magic reverence. It's easy to argue that a smaller number is good enough.
There are certainly less over-write worries if you can handle a few (4, 5, 6) simultaneously logged errors of sufficient size to be useful (must capture all of the panic strings, backtrace and register dump plus "enough" lines before the panic to see any obvious issues).
If you only get to store two errors, then perhaps one non-over writable panic type entry, and one other "most recent" type entry?
With just one, like current EFI, then there are certainly hard choices that might not be the best for certain pathological situations.
-Tony
| |