Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 5 Jul 2012 15:21:06 -0700 | Subject | Re: [PATCH 01/10] random: make 'add_interrupt_randomness()' do something sane |
| |
On Thu, Jul 5, 2012 at 3:00 PM, Theodore Ts'o <tytso@mit.edu> wrote: > > Like this?
Looks fine to me.
Although I think it might be better to stay closer to what we used to do, and just 'or' in the action flags rather than make it some conditional. And then at the end, do
if (!(flags & __IRQF_TIMER)) add_interrupt_randomness(irq)
instead on that or'ed flags value. Otherwise gcc will create silly conditional moves (or worse still, conditional branches) just for that "random" variable assignment.
Linus
| |