Messages in this thread | | | From | Javier Martinez Canillas <> | Date | Thu, 5 Jul 2012 19:54:21 +0200 | Subject | Re: [PATCH net-next 13/15] netfilter: nfdbus: Add D-bus message parsing |
| |
On Wed, Jul 4, 2012 at 7:30 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > On Mon, Jul 02, 2012 at 05:43:43PM +0200, Javier Martinez Canillas wrote: >> On 06/29/2012 07:11 PM, Pablo Neira Ayuso wrote: >> > On Fri, Jun 29, 2012 at 05:45:52PM +0100, Vincent Sanders wrote: >> >> From: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> >> >> >> The netfilter D-Bus module needs to parse D-bus messages sent by >> >> applications to decide whether a peer can receive or not a D-Bus >> >> message. Add D-bus message parsing logic to be able to analyze. >> > >> > Not talking about the entire patchset, only about the part I'm >> > responsible for. >> > >> > I don't see why you think this belong to netfilter at all. >> > >> > This doesn't integrate into the existing filtering infrastructure, >> > neither it extends it in any way. >> > >> >> Hello Pablo, >> >> Thanks a lot for your feedback. >> >> This is the first of a set of patches that adds a netfilter module to parse >> D-Bus messages, the complete patch-set is: >> >> [PATCH 13/15] netfilter: nfdbus: Add D-bus message parsing >> [PATCH 14/15] netfilter: nfdbus: Add D-bus match rule implementation >> [PATCH 15/15] netfilter: add netfilter D-Bus module >> >> patches 13 and 14 just include D-Bus helper code to be used by the netfilter >> module (added on patch 15) and specially the dbus_filter netfilter hook function. > > I see, the use of the netfilter hooks seems to be the only reason why > you consider these chunks belong to netfilter. > >> For the next post version we will reorganize the patches so first the D-Bus >> netfilter module is added with an empty dbus_filter function and then added the >> D-Bus helper code. >> >> Also, we will move the nfdbus netfilter module to net/bus so is not inside the >> netfilter core code. > > Yes, please, remove this stuff from my directory tree, I believe this > filtering infrastructure has not much to do with Netfilter itself. > > It uses the connector to communicate kernel <-> userspace instead of > nfnetlink and, as said, it does neither integrate into existing > filtering kernel/userspace infrastructure nor integrates into it. > > So, please, if you plan to give another try to this patchset, move > this to your net/bus directory as you propose and find a different > (better) name for the filtering part (just to avoid confusion in the > future). > > Thanks.
Hi Pablo,
Thanks a lot for your feedback and comments.
On a next patch-set post I'll move to net/bus and change the name as you suggest.
Best regards,
-- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |