lkml.org 
[lkml]   [2012]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/19] Staging: xgifb: Improve debug strings.
    Hi,

    On Thu, Jul 05, 2012 at 04:45:48PM +0200, Miguel Gómez wrote:
    > if (!htotal || !vtotal) {
    > - pr_debug("XGIfb: Invalid 'var' information\n");
    > + pr_debug("Invalid 'var' information\n");
    [...]
    > - pr_err("xgifb: invalid value for option: %s\n", fullopt);
    > + pr_err("Invalid value for option: %s\n", fullopt);
    [...]
    > - pr_info("xgifb: options: %s\n", options);
    > + pr_info("Options: %s\n", options);

    Can you really remove the driver prefix?

    > if (reg1 != 0xa1) { /*I/O error */
    > - dev_err(&pdev->dev, "I/O error!!!");
    > + dev_err(&pdev->dev, "I/O error!!!\n");

    Those exclamation marks are just redundant noise.

    > - dev_err(&pdev->dev, "unable request memory size %x\n",
    > + dev_err(&pdev->dev, "Unable request memory size %x\n",
    [...]
    > - dev_err(&pdev->dev, "no supported video mode found\n");
    > + dev_err(&pdev->dev, "No supported video mode found\n");
    [...]
    > - dev_info(&pdev->dev, "added MTRR\n");
    > + dev_info(&pdev->dev, "Added MTRR\n");
    [...]
    > - dev_err(&pdev->dev, "video BIOS not available\n");
    > + dev_err(&pdev->dev, "Video BIOS not available\n");
    [...]
    > - dev_err(&pdev->dev, "video BIOS corrupted\n");
    > + dev_err(&pdev->dev, "Video BIOS corrupted\n");

    What is the improvement?

    A.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-05 20:21    [W:4.720 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site