Messages in this thread | | | Date | Wed, 4 Jul 2012 13:40:42 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 02/10] perf, tool: Fix pmu object initialization |
| |
On Wed, Jul 04, 2012 at 12:30:48PM +0200, Peter Zijlstra wrote: > On Wed, 2012-07-04 at 00:00 +0200, Jiri Olsa wrote: > > The internal pmu list was never used. With each perf_pmu__find() call > > the pmu structure was created new by parsing sysfs. Beside this it > > caused memory leaks. We now keep all pmus by adding them to the list. > > > > Also, pmu_lookup() should return pmus that do not expose the format > > specifier in sysfs. > > > > We need a valid internal pmu list in a later patch to iterate over all > > pmus that exist in the system. > > > > Signed-off-by: Robert Richter <robert.richter@amd.com> > > [ added same treatment for 'event' sysfs group attribute ] > > Signed-off-by: Jiri Olsa <jolsa@redhat.com> > > Are we missing a From: ?
so first SOB is not enough then.. I'll add it in next version
jirka >
| |