lkml.org 
[lkml]   [2012]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] memcg: print more detailed info while memcg oom happening
    On 07/04/2012 04:29 PM, Kamezawa Hiroyuki wrote:
    > (2012/06/28 20:06), Sha Zhengju wrote:
    >> From: Sha Zhengju <handai.szj@taobao.com>
    >>
    >> While memcg oom happening, the dump info is limited, so add this
    >> to provide memcg page stat.
    >>
    >> Signed-off-by: Sha Zhengju <handai.szj@taobao.com>
    > Could you split this into a different series ?
    > seems good to me in general but...one concern is hierarchy handling.
    >
    > IIUC, the passed 'memcg' is the root of hierarchy which gets OOM.
    > So, the LRU info, which is local to the root memcg, may not contain any good
    > information. I think you should visit all memcg under the tree.
    >
    Yes, you're right!
    I did not handle hierarchy here, and just now I make a test case to
    prove this.
    I'll split it to another series later.

    Thanks for reviewing!


    Thanks,
    Sha


    \
     
     \ /
      Last update: 2012-07-04 14:01    [W:3.477 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site