lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define
From
On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens
<heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> The LO_ARG define needs to consider endianness also for 32 bit builds.
>
> The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode
> because the LO_ARG define resulted in a BPF program which read the upper
> halve of the 64 bit system call arguments instead of the lower halves.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Good catch; thanks for the fix!

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2012-08-01 04:41    [W:0.055 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site