Messages in this thread | | | Date | Wed, 1 Aug 2012 00:48:17 +0400 | Subject | Re: wlcore: might_sleep operation in interrupt handler | From | Denis Yefremov <> |
| |
More precise (IRQF_ONESHOT flag may be used):
int __devinit wlcore_probe(struct wl1271 *wl, struct platform_device *pdev) { ... if (wl->platform_quirks & WL12XX_PLATFORM_QUIRK_EDGE_IRQ) irqflags = IRQF_TRIGGER_RISING; else irqflags = IRQF_TRIGGER_HIGH | IRQF_ONESHOT;
ret = request_threaded_irq(wl->irq, wl12xx_hardirq, wlcore_irq, irqflags, pdev->name, wl);
2012/8/1 Johannes Berg <johannes@sipsolutions.net>: > On Tue, 2012-07-31 at 22:28 +0400, Denis Yefremov wrote: >> Interrupt handler wlcore_irq in wlcore/main.c file >> invokes mutex_lock that is might sleep operation. > >> int __devinit wlcore_probe(struct wl1271 *wl, struct platform_device *pdev) >> { >> ... >> ret = request_threaded_irq(wl->irq, wl12xx_hardirq, wlcore_irq, >> irqflags, >> pdev->name, wl); > > Yes, umm, why do you think they're using a *threaded* IRQ? :-) > > johannes >
| |