lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
    On Tue, Jul 31, 2012 at 04:09:08PM +0100, Lee Jones wrote:
    > On 31/07/12 15:56, Mark Brown wrote:

    > >To reiterate, this is in *no* way urgent or even a bug fix.

    > It fixes sound in our driver.

    > Without this the card failes to instantiate.

    You're kidding, right? Fix the actual error.

    > Isn't the return code incorrect? There are a multitude of reasons
    > why snd_soc_dapm_new_control() would fail. No-memory is just one of
    > them, so why do we force this probable lie?

    I don't think anyone actually cares what the error code is, feel free to
    pick another random number.


    \
     
     \ /
      Last update: 2012-07-31 18:02    [W:3.433 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site