lkml.org 
[lkml]   [2012]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 23/73] r8169: RxConfig hack for the 8168evl.
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: françois romieu <romieu@fr.zoreil.com>

    commit eb2dc35d99028b698cdedba4f5522bc43e576bd2 upstream.

    The 8168evl (RTL_GIGA_MAC_VER_34) based Gigabyte GA-990FXA motherboards
    are very prone to NETDEV watchdog problems without this change. See
    https://bugzilla.kernel.org/show_bug.cgi?id=42899 for instance.

    I don't know why it *works*. It's depressingly effective though.

    For the record:
    - the problem may go along IOMMU (AMD-Vi) errors but it really looks
    like a red herring.
    - the patch sets the RX_MULTI_EN bit. If the 8168c doc is any guide,
    the chipset now fetches several Rx descriptors at a time.
    - long ago the driver ignored the RX_MULTI_EN bit.
    e542a2269f232d61270ceddd42b73a4348dee2bb changed the RxConfig
    settings. Whatever the problem it's now labeled a regression.
    - Realtek's own driver can identify two different 8168evl devices
    (CFG_METHOD_16 and CFG_METHOD_17) where the r8169 driver only
    sees one. It sucks.

    Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/realtek/r8169.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
    index 7260aa7..d7a04e0 100644
    --- a/drivers/net/ethernet/realtek/r8169.c
    +++ b/drivers/net/ethernet/realtek/r8169.c
    @@ -3894,6 +3894,7 @@ static void rtl_init_rxcfg(struct rtl8169_private *tp)
    case RTL_GIGA_MAC_VER_22:
    case RTL_GIGA_MAC_VER_23:
    case RTL_GIGA_MAC_VER_24:
    + case RTL_GIGA_MAC_VER_34:
    RTL_W32(RxConfig, RX128_INT_EN | RX_MULTI_EN | RX_DMA_BURST);
    break;
    default:

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-31 07:41    [W:4.040 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site