Messages in this thread | | | Date | Mon, 30 Jul 2012 15:28:32 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] Revert "hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb" |
| |
On Fri, 27 Jul 2012 22:45:04 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > > > Unless Aneesh has another reason for the patch, it should be reverted > > to preserve hugetlb page sharing locking. > > > > I guess we want to take this patch as a revert patch rather than > dropping the one in -mm. That would help in documenting the i_mmap_mutex > locking details in commit message. Or may be we should add necessary > comments around the locking ?
Code comments would be better if possible - we shouldn't force people to dig around in git history to understand small code snippets.
| |