lkml.org 
[lkml]   [2012]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
On 29/07/12 21:42, Mark Brown wrote:
> On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote:
>
>> + if (of_get_property(np, "stericsson,use-pinctrl", NULL))
>> + msp->use_pinctrl = true;
>> + else
>> + msp->use_pinctrl = false;
>
> I don't recall seeing any response to my query about this on the first
> iteration. Please don't just ignore review comments.

It wasn't intentional. I must have missed it before.

> This doesn't seem particularly sane... why is this conditional?

It's conditional because only MSP1 and MSP3 have pinctrl support.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-07-30 09:21    [W:0.077 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site