lkml.org 
[lkml]   [2012]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 6/6] ftrace/x86: Add save_regs for i386 function calls
    From
    Date
    On Tue, 2012-07-03 at 14:27 +0900, Masami Hiramatsu wrote:
    > (2012/07/03 5:03), Steven Rostedt wrote:

    > > +GLOBAL(ftrace_regs_call)
    > > + call ftrace_stub
    > > +
    > > + addl $4,%esp /* Skip pt_regs */
    >
    > Hmm, you need to restoring flags here, because
    > original flags is clobbered by KERNEL_CS.
    >
    > movl 14*4+4(%esp), %edx
    > movl %edx, 13*4+4(%esp)

    Ah, you're right. I'll update it. I need to make changes anyway, because
    I found that if I have a kprobe using ftrace and enable function graph
    tracer, the machine triple faults. I'm working on fixing that now.

    Thanks!

    -- Steve




    \
     
     \ /
      Last update: 2012-07-03 14:21    [W:2.129 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site