lkml.org 
[lkml]   [2012]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 06/24] xen: missing includes
>>> On 26.07.12 at 17:33, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
> --- a/include/xen/interface/xen.h
> +++ b/include/xen/interface/xen.h
> @@ -10,7 +10,10 @@
> #define __XEN_PUBLIC_XEN_H__
>
> #include <asm/xen/interface.h>
> +#include <linux/types.h>
> +#ifdef CONFIG_X86
> #include <asm/pvclock-abi.h>
> +#endif

Rather than hacking around this, why not clean it up:
asm/pvclock-abi.h clearly isn't intended to be included here
(from the perspective of the origin of xen/interface/xen.h, at
least), nor is linux/types.h.

Or if it is really needed to deviate from the original header in
this respect, then clearly the inclusion ought to not be arch
specific or be moved to an arch specific header.

Jan

>
> /*
> * XEN "SYSTEM CALLS" (a.k.a. HYPERCALLS).




\
 
 \ /
  Last update: 2012-07-27 09:41    [W:0.514 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site