Messages in this thread | | | Date | Thu, 26 Jul 2012 17:42:21 +0800 | From | Alex Shi <> | Subject | Re: [PATCH 1/2] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and code clean up |
| |
On 07/26/2012 05:37 PM, Mike Galbraith wrote:
> On Thu, 2012-07-26 at 13:27 +0800, Alex Shi wrote: > >> if (affine_sd) { >> - if (cpu == prev_cpu || wake_affine(affine_sd, p, sync)) >> + if (wake_affine(affine_sd, p, sync)) >> prev_cpu = cpu; >> >> new_cpu = select_idle_sibling(p, prev_cpu); > > Hm, if cpu == prev_cpu, asking wake_affine() if it's ok to put wakee > back where it came from is wasted cycles.. that's where the task is > headed regardless of reply.
Sure. You'r right.
> > -Mike >
| |