Messages in this thread | | | Date | Thu, 26 Jul 2012 18:33:33 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH] Shorten constant names for EFI variable attributes |
| |
On Thu, Jul 26, 2012 at 11:28:32AM -0600, Khalid Aziz wrote:
> I also do not believe that kernel must use the constant names > mentioned in the specification especially when the name reaches 50 > characters. We can not get away from having to create aliases. Do > you think having aliases in efi.h can cause mixed use of long names > and short names in future code in the kernel? Can we address this by > suggesting to future code authors that they should use the short > names in their code? Should we consider inclusion of this patch in > the kernel?
I'd be surprised if it were a problem - we should catch any of those cases in code review, or gate the aliases under #ifndef __KERNEL__
-- Matthew Garrett | mjg59@srcf.ucam.org
| |