| Date | Thu, 26 Jul 2012 23:48:17 +0800 | Subject | Re: [RFC PATCH 12/13] driver core: firmware loader: use small timeout for cache device firmware | From | Ming Lei <> |
| |
On Thu, Jul 26, 2012 at 8:36 PM, Borislav Petkov <bp@amd64.org> wrote: > On Wed, Jul 25, 2012 at 01:00:12AM +0800, Ming Lei wrote: >> Because device_cache_firmwares only cache the firmware which has been >> loaded sucessfully at leat once, using a small loading timeout should > > least > >> be OK. > > Your commit message doesn't explain why exactly we decrease the timeout:
I have explained it. Because the firmware has been loaded successfully at least once, so it is very probably to not timeout.
> you should probably say that this patch overrides the default 60s > timeout because we're in pre-suspend/-hibernate mode where we have > userspace and are able to load the firmware quickly.
No, it is not what I was saying.
Thanks, -- Ming Lei
|